[PATCH] mfplat: Implement MFHeap[Alloc|Free].

Gijs Vermeulen gijsvrm at gmail.com
Thu Feb 21 13:57:46 CST 2019


Hi Nikolay,

Thanks for the review!

Op do 21 feb. 2019 om 20:39 schreef Nikolay Sivov <nsivov at codeweavers.com>:

> If we're going to trace this, please use debugstr_a().
>

Will do.


> Also please add a basic test like alloc(16) -> free() or similar, to
> cover at least something.
>

I initially made some to check if the reserved parameters were validated
(see [1]),
but decided against adding them. I'll add the basic case.


> Did you find some application calling this directly?
>

I didn't, but thought it looked simple enough to implement.

Kind regards,
Gijs

[1] https://testbot.winehq.org/JobDetails.pl?Key=48070
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190221/9e303606/attachment-0001.html>


More information about the wine-devel mailing list