[PATCH] server: Add new pipe servers to the end of the servers list.

Jacek Caban jacek at codeweavers.com
Tue Feb 26 07:56:59 CST 2019

Hi Huw,

On 2/26/19 12:06 PM, Huw Davies wrote:
> This ensures instances created first will be connected to first.
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41670
> Signed-off-by: Huw Davies <huw at codeweavers.com>
> ---
>   dlls/kernel32/tests/pipe.c | 38 ++++++++++++++++++++++++++++++++++++++
>   server/named_pipe.c        |  2 +-
>   2 files changed, 39 insertions(+), 1 deletion(-)

While the patch looks good and has my sign-off, note that it's quite 
incomplete. For example, the order of used servers takes into account 
order of ConnectNamedPipe() calls. I extended your tests to show that 
it's quite incorrect. Also current code will prefer servers created 
earlier even if they just entered listening state while others are 
waiting longer.

Could you please try the attached follow-up patch and see if the app is 
fine with it?



-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 12533 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190226/5de42a5c/attachment-0001.bin>

More information about the wine-devel mailing list