[PATCH 1/9] ntoskrnl.exe/tests: Add object reference tests.

Zebediah Figura z.figura12 at gmail.com
Tue Feb 26 10:18:42 CST 2019



On 2/26/19 10:12 AM, Jacek Caban wrote:
> Hi Zebediah,
> 
> On 2/26/19 4:05 PM, Zebediah Figura wrote:
>> On 2/26/19 6:38 AM, Jacek Caban wrote:
>>> +    if (sizeof(void *) != 4) /* avoid dealing with fastcall */
>>> +    {
>>> +        ObfReferenceObject(obj1);
>>> +        ObDereferenceObject(obj1);
>>> +    }
>>
>> The tests aren't going to run on 64-bit Windows,
> 
> 
> Did you mean 32-bit Windows?

I mean ntoskrnl driver tests don't run at all on 64-bit Windows, because 
it refuses to load unsigned drivers.

> 
> 
>> so it may be worth just adding fastcall thunks like we have in
>> kernel32:sync.
> 
> 
> The test is not very interesting anyway. That, combined with the fact
> that actual 32-bit Windows are rather rare, made me think that it's not
> worth the trouble. Could we leave it as a possible follow-up?

Sure, no objection from me.



More information about the wine-devel mailing list