[PATCH 1/3] Mark certain internal functions, such as

André Hentschel nerv at dawncrow.de
Tue Feb 26 12:29:27 CST 2019


Hi Timothy and welcome to Wine development,

I haven't had a closer look at this patch, but still some notes below:

Am 26.02.19 um 11:03 schrieb Timothy Pearson:
>  wine_server_call(), as potentially crossing DLL module boundaries This is
>  needed to allow some systems, such as ppc64, to update module-specific
>  registers (TOC)

Could you please choose a short subject and then add a longer explanation above the sign-off when necessary?

> Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
> ---
>  dlls/shell32/shell32_main.c |  2 +-
>  include/windef.h            |  7 +++++++
>  include/wine/library.h      | 18 +++++++++---------
>  include/wine/server.h       |  2 +-
>  4 files changed, 18 insertions(+), 11 deletions(-)

Could you please split this patch into smaller ones?



More information about the wine-devel mailing list