[PATCH 1/2] setupapi: Fix typos.

Zhiyi Zhang zzhang at codeweavers.com
Wed Feb 27 09:54:50 CST 2019


On 27/02/2019 23:48, Zebediah Figura wrote:
> On 2/27/19 8:44 AM, Zhiyi Zhang wrote:
>> Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
>> ---
>>   dlls/setupapi/devinst.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
>> index 537b335176..46987c8eb9 100644
>> --- a/dlls/setupapi/devinst.c
>> +++ b/dlls/setupapi/devinst.c
>> @@ -77,8 +77,8 @@ static const WCHAR Enum[] = {'S','y','s','t','e','m','\\',
>>   static const WCHAR DeviceDesc[] = {'D','e','v','i','c','e','D','e','s','c',0};
>>   static const WCHAR DeviceInstance[] = {'D','e','v','i','c','e','I','n','s','t','a','n','c','e',0};
>>   static const WCHAR DeviceParameters[] = {'D','e','v','i','c','e',' ','P','a','r','a','m','e','t','e','r','s',0};
>> -static const WCHAR HardwareId[] = {'H','a','r','d','w','a','r','e','I','D',0};
>> -static const WCHAR CompatibleIDs[] = {'C','o','m','p','a','t','i','b','l','e','I','d','s',0};
>> +static const WCHAR HardwareID[] = {'H','a','r','d','w','a','r','e','I','D',0};
>> +static const WCHAR CompatibleIDs[] = {'C','o','m','p','a','t','i','b','l','e','I','D','s',0};
>>   static const WCHAR Service[] = {'S','e','r','v','i','c','e',0};
>>   static const WCHAR Driver[] = {'D','r','i','v','e','r',0};
>>   static const WCHAR ConfigFlags[] = {'C','o','n','f','i','g','F','l','a','g','s',0};
>> @@ -607,7 +607,7 @@ struct PropertyMapEntry
>>     static const struct PropertyMapEntry PropertyMap[] = {
>>       { REG_SZ, "DeviceDesc", DeviceDesc },
>> -    { REG_MULTI_SZ, "HardwareId", HardwareId },
>> +    { REG_MULTI_SZ, "HardwareID", HardwareID },
>>       { REG_MULTI_SZ, "CompatibleIDs", CompatibleIDs },
>>       { 0, NULL, NULL }, /* SPDRP_UNUSED0 */
>>       { REG_SZ, "Service", Service },
>>
>
> Registry values are case-insensitive; I don't think this is clearly better.
>
>
Yes they are case-insensitive. I just think it's better to keep them consistent with other values.



More information about the wine-devel mailing list