[PATCH v2 1/2] vbscript: Allow most keywords to be used as 'dot' identifiers.

[Brendan McGrath]

Thanks Jacek - yeah I thought of that afterwards - I will make that change.

I also need to look in to how to run the test on Windows, as Windows had 
failures (when I actually ran the tests). So I'll make sure the tests 
pass on Windows too (by removing support for the keywords that don't) 
before submitting the next version.

On 28/2/19 5:42 am, Jacek Caban wrote:
> Hi Brendan,
>
> The patch looks mostly good to me. I have just one suggestion:
>
> On 2/27/19 7:28 AM, Brendan McGrath wrote:
>>   #define DISPID_TESTOBJ_PROPGET      2000
>>   #define DISPID_TESTOBJ_PROPPUT      2001
>> +#define DISPID_TESTOBJ_REM          2002
>> +#define DISPID_TESTOBJ_TRUE         2003
>> +#define DISPID_TESTOBJ_FALSE        2004
>> +#define DISPID_TESTOBJ_NOT          2005
>> +#define DISPID_TESTOBJ_AND          2006
>> +#define DISPID_TESTOBJ_OR           2007
>> +#define DISPID_TESTOBJ_XOR          2008
>> +#define DISPID_TESTOBJ_EQV          2009
>> +#define DISPID_TESTOBJ_IMP          2010
>> +#define DISPID_TESTOBJ_IS           2011
>> +#define DISPID_TESTOBJ_MOD          2012
>> +#define DISPID_TESTOBJ_CALL         2013
>> +#define DISPID_TESTOBJ_DIM          2014
>> +#define DISPID_TESTOBJ_SUB          2015
>> +#define DISPID_TESTOBJ_FUNCTION     2016
>> +#define DISPID_TESTOBJ_GET          2017
>> +#define DISPID_TESTOBJ_LET          2018
>> +#define DISPID_TESTOBJ_CONST        2019
>> +#define DISPID_TESTOBJ_IF           2020
>> +#define DISPID_TESTOBJ_ELSE         2021
>> +#define DISPID_TESTOBJ_ELSEIF       2022
>> +#define DISPID_TESTOBJ_END          2023
>> +#define DISPID_TESTOBJ_THEN         2024
>> +#define DISPID_TESTOBJ_EXIT         2025
>> +#define DISPID_TESTOBJ_WHILE        2026
>> +#define DISPID_TESTOBJ_WEND         2027
>> +#define DISPID_TESTOBJ_DO           2028
>> +#define DISPID_TESTOBJ_LOOP         2029
>> +#define DISPID_TESTOBJ_UNTIL        2030
>> +#define DISPID_TESTOBJ_FOR          2031
>> +#define DISPID_TESTOBJ_TO           2032
>> +#define DISPID_TESTOBJ_EACH         2033
>> +#define DISPID_TESTOBJ_IN           2034
>> +#define DISPID_TESTOBJ_SELECT       2035
>> +#define DISPID_TESTOBJ_CASE         2036
>> +#define DISPID_TESTOBJ_BYREF        2037
>> +#define DISPID_TESTOBJ_BYVAL        2038
>> +#define DISPID_TESTOBJ_OPTION       2039
>> +#define DISPID_TESTOBJ_NOTHING      2040
>> +#define DISPID_TESTOBJ_EMPTY        2041
>> +#define DISPID_TESTOBJ_NULL         2042
>> +#define DISPID_TESTOBJ_CLASS        2043
>> +#define DISPID_TESTOBJ_SET          2044
>> +#define DISPID_TESTOBJ_NEW          2045
>> +#define DISPID_TESTOBJ_PUBLIC       2046
>> +#define DISPID_TESTOBJ_PRIVATE      2047
>> +#define DISPID_TESTOBJ_NEXT         2048
>> +#define DISPID_TESTOBJ_ON           2049
>> +#define DISPID_TESTOBJ_RESUME       2050
>> +#define DISPID_TESTOBJ_GOTO         2051
>
>
> You could use just single DISPID (say, DISPID_TESTOBJ_KEYWORD) and 
> return it for all keywords.
>
>
> Thanks,
>
> Jacek
>