[PATCH] taskschd/tests: Fix some memory leaks (Valgrind).

Dmitry Timoshkov dmitry at baikal.ru
Tue Jan 15 08:20:04 CST 2019


Sven Baars <sven.wine at gmail.com> wrote:

>      hr = ITaskService_GetFolder(service, slash, &folder);
>  todo_wine
>      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME), "expected ERROR_INVALID_NAME, got %#x\n", hr);
> +    if (hr == S_OK) ITaskFolder_Release(folder);
>  
>      hr = ITaskService_GetFolder(service, dot, &folder);
>  todo_wine
>      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME) || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) /* win7 */,
>         "expected ERROR_INVALID_NAME, got %#x\n", hr);
> +    if (hr == S_OK) ITaskFolder_Release(folder);

Fixing Wine code and removing the todo_wine would be a more appropriate fix.

-- 
Dmitry.



More information about the wine-devel mailing list