[PATCH] taskschd/tests: Fix some memory leaks (Valgrind).

[Sven Baars]

On 15-01-19 15:52, Dmitry Timoshkov wrote:
> Sven Baars <sven.wine at gmail.com> wrote:
>
>>>>      hr = ITaskService_GetFolder(service, slash, &folder);
>>>>  todo_wine
>>>>      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME), "expected ERROR_INVALID_NAME, got %#x\n", hr);
>>>> +    if (hr == S_OK) ITaskFolder_Release(folder);
>>>>  
>>>>      hr = ITaskService_GetFolder(service, dot, &folder);
>>>>  todo_wine
>>>>      ok(hr == HRESULT_FROM_WIN32(ERROR_INVALID_NAME) || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) /* win7 */,
>>>>         "expected ERROR_INVALID_NAME, got %#x\n", hr);
>>>> +    if (hr == S_OK) ITaskFolder_Release(folder);
>>> Fixing Wine code and removing the todo_wine would be a more appropriate fix.
>>>
>> Of course, but at the moment I'm just trying to fix all memory leaks
>> that are present in the tests during the code freeze. That way it is
>> easier to find and fix actual memory leaks in wine itself after the code
>> freeze. I already have some patches lined up for that as well.
> The problem is that this kind of fixes would have to be be removed later,
> so it's better to not introduce them in the first place.
>
But the effort of removing that line is a lot smaller than the effort of
investigating a trace with a lot of question marks and wrong line
numbers, which is what this leak generates:

==32665== 12 bytes in 1 blocks are definitely lost in loss record 105 of 665
==32665==    at 0x7BC507B3: RtlAllocateHeap (heap.c:260)
==32665==    by 0x5FBAD8F: heap_alloc (heap.h:29)
==32665==    by 0x5FBAD8F: TaskFolder_create (???:0)
==32665==    by 0x5FC32E5: TaskService_GetFolder (task.c:3757)
==32665==    by 0x4CE92F5: ITaskService_GetFolder (taskschd.h:624)
==32665==    by 0x4CE92F5: test_GetFolder (???:0)