[PATCH v2 resend 1/2] kernelbase/tests: Relax tests for WaitOnAddress().

Zebediah Figura z.figura12 at gmail.com
Sun Jan 27 22:48:43 CST 2019


On 1/27/19 10:34 PM, Greg wrote:
> On 28/1/19 8:54 am, Marvin wrote:
>> Hi,
>>
>> While running your changed tests on Windows, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I might be
>> wrong, but could you please double-check?
>>
>> Full results can be found at:
>> https://testbot.winehq.org/JobDetails.pl?Key=46762
>>
>> Your paranoid android.
>>
>>
>> === wxppro (32 bit report) ===
>>
>> kernelbase:
>> sync: Timeout
>>
>>
> Thanks for resubmitting this Zeb.
> 
> Putting aside the mysteries of kernelbase and WaitOnAddress existing in
> windows XP but notInterlockedCompareExchange64, it seems from my
> research that InterlockedCompareExchange should exist on windows XP.
> Would it be feasible and acceptable to change the size of 'compare' to a
> 32 bits and use InterlockedCompareExchange instead?
> 
> Regards,
> 
> Greg
> 
> 

Yes, that is probably the best thing to do. If I receive no other 
feedback, I will resend the patch with that changed.



More information about the wine-devel mailing list