[PATCH 3/3] debug.h: hint a compiler: TRACE is not executed in common usage

Konstantin Kharlamov hi-angel at yandex.ru
Tue Jan 29 02:45:37 CST 2019


On 29.01.2019 11:01, Alexandre Julliard wrote:
> Konstantin Kharlamov <hi-angel at yandex.ru> writes:
> 
>> On 29.01.2019 01:17, Marvin wrote:
>>> Thank you for your contribution to Wine!
>>>
>>> This is an automated notification to let you know that your patch has
>>> been reviewed and its status set to "Rejected".
>>>
>>> This means that the patch has been rejected by a reviewer. You should
>>> have received a mail explaining why it was rejected. You need to fix
>>> the issue and resend the patch, or if you are convinced that your
>>> patch is good as is, you should reply to the rejection message with
>>> your counterarguments.
>>>
>>> If you do not understand the reason for this status, disagree with our
>>> assessment, or are simply not sure how to proceed next, please ask for
>>> clarification by replying to this email.
>>
>> Hi, I don't understand, why the 3-rd patch was marked rejected? AFAIK
>> it's being discussed.
> 
> I explained that such micro-optimizations won't be accepted, unless
> there is clear evidence that they make a difference. Your numbers are
> not convincing enough I'm afraid.

But why? It's still an optimization, and as being a burden it is very tiny. It is definitely smaller than the burden that my rejected refactoring was removing, why can't it be accepted?

Okay, if we're into this discussion: can you please formalize, what burden does it add from your point of view?



More information about the wine-devel mailing list