[PATCH] strmbase: Fix some memory leaks (Valgrind).
Alexandre Julliard
julliard at winehq.org
Tue Jan 29 12:21:33 CST 2019
Sven Baars <sven.wine at gmail.com> writes:
> for (i = 0; i < This->enumMediaDetails.cMediaTypes; i++)
> {
> - This->enumMediaFunction(This->basePin, i,&amt);
> - if (FAILED(CopyMediaType(&This->enumMediaDetails.pMediaTypes[i], &amt)))
> + This->enumMediaFunction(This->basePin, i, &amt);
> + hr = CopyMediaType(&This->enumMediaDetails.pMediaTypes[i], &amt);
> + FreeMediaType(&amt);
The extra copy doesn't seem necessary, you could fetch directly into the
destination array.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list