[PATCH] regedit: Remove redundant NULL check before heap_free()

Michael Stefaniuc mstefani at winehq.org
Tue Jan 29 13:38:06 CST 2019


Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
 programs/regedit/regproc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c
index 4ef99ec3ca..28402dc3cd 100644
--- a/programs/regedit/regproc.c
+++ b/programs/regedit/regproc.c
@@ -731,11 +731,8 @@ static WCHAR *quoted_value_name_state(struct parser *parser, WCHAR *pos)
 {
     WCHAR *val_name = pos, *p;
 
-    if (parser->value_name)
-    {
-        heap_free(parser->value_name);
-        parser->value_name = NULL;
-    }
+    heap_free(parser->value_name);
+    parser->value_name = NULL;
 
     if (!REGPROC_unescape_string(val_name, &p))
         goto invalid;
-- 
2.20.1




More information about the wine-devel mailing list