[PATCH] kerberos: Fix compilation on systems where SONAME_LIBKRB5 is not defined.

[Dmitry Timoshkov]

Hans Leidekker <hans at codeweavers.com> wrote:

> On Tue, 2019-07-02 at 17:02 +0800, Dmitry Timoshkov wrote:
> > Where do you see this? Note that this code is inside an #ifdef SONAME_LIBGSSAPI_KRB5
> > > block and configure should disable gssapi when it can't detect krb5. This means that
> > > SONAME_LIBGSSAPI_KRB5 should not be set when SONAME_LIBKRB5 isn't.
> > 
> > I can confirm that on my system configure undefs SONAME_LIBGSSAPI_KRB5.
> > 
> > Unfortunately that's not on one of my machines. According to the reporter,
> > configure fails to find libkrb55.so but successfully locates libgssapi.so,
> > and configure log confirms that.
> 
> Sounds like a broken install. To fix this I think it would be better to improve
> our configure check than to add more (nested) ifdefs.

I believe that the added ifdefs are actually necessary, and they logically
separate libkrb5 functionality from libgssapi one. Without libkrb5 the only
things that won't be supported are custom credentials and the ticket cache,
everything else works just fine.

> AcquireCredentialsHandle won't be very useful without these krb5 functions.

It works just fine with cached system credentials.

-- 
Dmitry.