[PATCH] kerberos: Fix compilation on systems where SONAME_LIBKRB5 is not defined.

[Dmitry Timoshkov]

Hans Leidekker <hans at codeweavers.com> wrote:

> On Tue, 2019-07-02 at 18:14 +0800, Dmitry Timoshkov wrote:
> > Sounds like a broken install. To fix this I think it would be better to improve
> > > our configure check than to add more (nested) ifdefs.
> > 
> > I believe that the added ifdefs are actually necessary, and they logically
> > separate libkrb5 functionality from libgssapi one. Without libkrb5 the only
> > things that won't be supported are custom credentials and the ticket cache,
> > everything else works just fine.
> > 
> > > AcquireCredentialsHandle won't be very useful without these krb5 functions.
> > 
> > It works just fine with cached system credentials.
> 
> gssapi itself depends on krb5, so there's no reason to build with partial support.

Apparently there are configurations where that's not the case, and supporting them
isn't that hard as the patch shows.

> The user will have it installed but can't make use of it, and the developer will
> not be warned that support is missing.

I won't argue that whether it's a useful configuration, but the patch solves
both a compilation bug and and makes kerberos.dll at least partially working.

-- 
Dmitry.