[PATCH 3/3] d3drm: Return error if setting viewport field-of-view to zero or negative value.

Henri Verbeet hverbeet at gmail.com
Mon Jul 8 09:28:57 CDT 2019


On Fri, 5 Jul 2019 at 18:52, Jeff Smith <whydoubt at gmail.com> wrote:
> @@ -2157,6 +2157,8 @@ static void test_Viewport(void)
>      ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
>      hr = IDirect3DRMViewport_GetDirect3DViewport(viewport, NULL);
>      ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
> +    hr = IDirect3DRMViewport_SetField(viewport, 0.0);
> +    ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
>
>      IDirect3DRMViewport_Release(viewport);
>      ref4 = get_refcount((IUnknown *)d3drm1);
> @@ -2249,6 +2251,8 @@ static void test_Viewport(void)
>      ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
>      hr = IDirect3DRMViewport2_GetDirect3DViewport(viewport2, NULL);
>      ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
> +    hr = IDirect3DRMViewport2_SetField(viewport2, 0.0);
> +    ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr);
>
>      IDirect3DRMViewport2_Release(viewport2);
>      ref4 = get_refcount((IUnknown *)d3drm1);

It's fairly minor, but please add the 'f' suffix on float constants. I
also notice you're not testing negative values.



More information about the wine-devel mailing list