[PATCH] comctl32: Always pass pcbRead to IStream_Read.

Nikolay Sivov nsivov at codeweavers.com
Tue Jul 30 13:40:37 CDT 2019


On 7/30/19 9:16 PM, Zebediah Figura wrote:

> On 7/30/19 1:09 PM, Vincent Povirk wrote:
>> Signed-off-by: Vincent Povirk <vincent at codeweavers.com>
>> ---
>> pcbRead is a required argument. Windows Forms has an IStream
>> implementation that depends on it:
>>
>> https://github.com/madewokherd/winforms/blob/36684d6dfd994f2a06dd6ef5fa73e01869e085ec/src/Common/src/UnsafeNativeMethods.cs#L5820 
>>
>>
>
> That's actually a bug in Mono, by my understanding. The CCW should be 
> able to handle NULL return value pointers. I've sent a patch for it: 
> <https://github.com/mono/mono/pull/15906>
>
>
Testing comctl32 side of this was the first thing I did. Read() is 
called with NULL argument most of the time, for both version 5 and 
version 6.



More information about the wine-devel mailing list