[PATCH v2 1/2] msscript: Cache state of IActiveScript in ScriptHost struct.
Jactry Zeng
jzeng at codeweavers.com
Sun Jun 2 10:22:25 CDT 2019
Hi Nikolay,
On 2019/6/1 下午10:54, Nikolay Sivov wrote:
> You could move current state check to this helper too.
>From tests of reset: https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/msscript.ocx/tests/msscript.c#l1076
It always call SetScriptState() even current state already was SCRIPTSTATE_INITIALIZED.
If we move current state checking to this helper, it will make these tests fail. So it will be better to check current state only in Eval()?
Thanks.
More information about the wine-devel
mailing list