[PATCH v4 1/2] ntdll/directory: Add support for EXT4 case folding per directory
Gabriel Ivăncescu
gabrielopcode at gmail.com
Wed Jun 12 06:56:31 CDT 2019
On 6/11/19 8:06 PM, Alexandre Julliard wrote:
> Huw Davies <huw at codeweavers.com> writes:
>
>> 1. I'm still sceptical on whether the name / fd thing is worth it,
>> however it doesn't look too bad so it's probably ok.
>
> It doesn't look so good to me. There's no reason to change the function
> on all platforms for something that is Linux specific. Simply open the
> directory in the ifdef linux block.
>
But that would make the fd parameter unused in other platforms, unless
you mean we open the dir in the *_stat function itself, but in that case
the name might be misleading a bit, since it also does an ioctl,
assuming it calls the *_ioctl function from there.
Would that be a good way to approach this?
More information about the wine-devel
mailing list