[PATCH v3] mshtml: Add support for DIID_HTMLDocumentEvents2 connection point sink.

Dmitry Timoshkov dmitry at baikal.ru
Wed Jun 19 10:26:04 CDT 2019


Jacek Caban <jacek at codeweavers.com> wrote:

> Signed-off-by: Jacek Caban <jacek at codeweavers.com>

Thanks for the very helpful and detailed reviews.

> On 6/19/19 4:54 PM, Dmitry Timoshkov wrote:
> > This patch makes event handling work in a fairly large and complex application.
> 
> 
> It's fine if don't share application's name, but having such statements 
> in git history doesn't make much sense. I'd suggest to just skip it.

That comment is not supposed to be included in the commit message (Alexandre
is very competent here, and doesn't include every bit of information provided
in the patch. The comment simply emphasizes that this patch makes a real world
app work, and not some weird test out of the blue (how it looks like with some
recent virtual subsystem related patches influx).

-- 
Dmitry.



More information about the wine-devel mailing list