[PATCH 04/10] d3drm: Introduce a d3drm_matrix structure.

[Henri Verbeet]

On Thu, 20 Jun 2019 at 10:16, Jeff Smith <whydoubt at gmail.com> wrote:
> I would advise against implementing d3drm_frame2_GetTransform and
> d3drm_frame1_GetTransform by calling on d3drm_frame3_GetTransform.
> While that currently would work, because the reference is ignored, it
> will not work with a properly-implemented d3drm_frame3_GetTransform.
> I have such a fix in my queue for GetTransform to properly use the
> reference, and so I would have to revert your changes to make it all
> correct.
> I suggest taking these hunks out, and just change 'memcpy(...)' to
> 'matrix = frame->transform' as you've done elsewhere.
>
You're right.

Henri