[v2 PATCH] mshtml: Add IHTMLDOMRange stub.

Jacek Caban jacek at codeweavers.com
Thu Jun 27 08:55:47 CDT 2019


Hi Nikolay,

On 6/27/19 12:46 PM, Nikolay Sivov wrote:
> +HRESULT HTMLDOMRange_Create(HTMLDocumentNode *doc, nsIDOMRange *nsrange, IHTMLDOMRange **p)


doc argument is unused now.


> diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
> index 586df7d8a5..cb5e930820 100644
> --- a/dlls/mshtml/tests/dom.c
> +++ b/dlls/mshtml/tests/dom.c
> @@ -10380,6 +10380,28 @@ static void test_docfrag(IHTMLDocument2 *doc)
>       IHTMLDocument2_Release(frag);
>   }
>   
> +static void test_domrange(IHTMLDocument2 *doc)
> +{
> +    IDocumentRange *doc_range;
> +    IHTMLDOMRange *range;
> +    HRESULT hres;
> +
> +    hres = IHTMLDocument2_QueryInterface(doc, &IID_IDocumentRange, (void **)&doc_range);
> +    ok(hres == S_OK || broken(hres == E_NOINTERFACE) /* XP */, "Failed to get IDocumentRange: %08x\n", hres);

> +
> +    if (FAILED(hres))
> +        return;
> +
> +    hres = IDocumentRange_createRange(doc_range, &range);
> +    ok(hres == S_OK, "Failed to create range, %08x\n", hres);
> +
> +    test_disp((IUnknown *)range, &DIID_DispHTMLDOMRange, NULL, NULL);
> +
> +    IHTMLDOMRange_Release(range);
> +
> +    IDocumentRange_Release(doc_range);
> +}
> +
>   static void check_quirks_mode(IHTMLDocument2 *doc)
>   {
>       test_compatmode(doc, "BackCompat");
> @@ -11077,6 +11099,7 @@ START_TEST(dom)
>       run_domtest(emptydiv_str, test_docfrag);
>       run_domtest(doc_blank, test_replacechild_elems);
>       run_domtest(doctype_str, test_doctype);
> +    run_domtest(doc_blank, test_domrange);


doc_blank_ie9 would be probably better. While it's possible to call this 
from C in other compatibility modes, it's not something scripts could 
do. Also you could skip the whole test depending on ie_ie9plus.


Thanks,

Jacek




More information about the wine-devel mailing list