[PATCH 2/2] bcrypt: Return STATUS_INVALID_PARAMETER when invalid flag passed to BCryptCreateHash.

Brendan McGrath brendan at redmandi.com
Tue Mar 5 02:52:11 CST 2019


Signed-off-by: Brendan McGrath <brendan at redmandi.com>
---
 dlls/bcrypt/bcrypt_main.c  | 2 +-
 dlls/bcrypt/tests/bcrypt.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c
index 1b84ace8abe..4fc50b51664 100644
--- a/dlls/bcrypt/bcrypt_main.c
+++ b/dlls/bcrypt/bcrypt_main.c
@@ -602,7 +602,7 @@ NTSTATUS WINAPI BCryptCreateHash( BCRYPT_ALG_HANDLE algorithm, BCRYPT_HASH_HANDL
     if (flags)
     {
         FIXME( "unimplemented flags %08x\n", flags );
-        return STATUS_NOT_IMPLEMENTED;
+        return STATUS_INVALID_PARAMETER;
     }
 
     if (!alg || alg->hdr.magic != MAGIC_ALG) return STATUS_INVALID_HANDLE;
diff --git a/dlls/bcrypt/tests/bcrypt.c b/dlls/bcrypt/tests/bcrypt.c
index 92b5a30e9fd..534b0326f2c 100644
--- a/dlls/bcrypt/tests/bcrypt.c
+++ b/dlls/bcrypt/tests/bcrypt.c
@@ -250,7 +250,6 @@ static void test_hash(const struct hash_test *test)
 
     /* test return on invalid flag */
     ret = pBCryptCreateHash(alg, &hash, buf, len, NULL, 0, 1);
-    todo_wine
     ok(ret == STATUS_INVALID_PARAMETER, "got %08x\n", ret);
 
     ret = pBCryptCreateHash(alg, &hash, buf, len, NULL, 0, 0);
-- 
2.17.1




More information about the wine-devel mailing list