[PATCH 2/5] mfplat: Implement MFCreatePresentationDescriptor().

Nikolay Sivov nsivov at codeweavers.com
Tue Mar 5 07:46:18 CST 2019


On 3/5/19 4:35 PM, Sven Baars wrote:

> On Tue, Mar 5, 2019 at 8:50 AM Nikolay Sivov <nsivov at codeweavers.com> wrote:
>> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
>> ---
>>   dlls/mfplat/mediatype.c    | 463 +++++++++++++++++++++++++++++++++++++
>>   dlls/mfplat/mfplat.spec    |   2 +-
>>   dlls/mfplat/tests/mfplat.c |  76 ++++++
>>   include/mfidl.idl          |   2 +
>>   4 files changed, 542 insertions(+), 1 deletion(-)
> Hi Nikolay,
>
> A stub implementation of the presentation descriptor is already
> present in main.c. Can't you use/move that one?

Hi.

The issue is that mfplat should not have its own media source 
implementation, that should be handled by plugin modules.

Those external media sources then can use stock implementation of 
presentation descriptor or implement something else.
Now, to create this stock implementation instance you'll need stream 
descriptor, for which you'll need media types.

That's why I left existing stubs for now, assuming they were added to 
fix some crashes. Eventually media source one will have to be removed.

>
> Sven



More information about the wine-devel mailing list