[PATCH v2] msacm32: Remove redundant not-NULL check (coccinellery)

Andrew Eikum aeikum at codeweavers.com
Wed Mar 6 08:26:14 CST 2019


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>

On Wed, Mar 06, 2019 at 12:02:32AM +0100, Michael Stefaniuc wrote:
> Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
> ---
> v2: !pad->hDrvr is NULL on all path leading to gotError so remove that
>     check too.
> 
> 
>  dlls/msacm32/driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c
> index e0c5fdd90e..13187b2204 100644
> --- a/dlls/msacm32/driver.c
> +++ b/dlls/msacm32/driver.c
> @@ -600,8 +600,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVER phad, HACMDRIVERID hadid, DWORD fdwOpe
>      return MMSYSERR_NOERROR;
>   gotError:
>      WARN("failed: ret = %08x\n", ret);
> -    if (pad && !pad->hDrvr)
> -	HeapFree(MSACM_hHeap, 0, pad);
> +    HeapFree(MSACM_hHeap, 0, pad);
>      return ret;
>  }
>  
> -- 
> 2.20.1
> 
> 
> 



More information about the wine-devel mailing list