[PATCH] msvcp90: Fix vtable alignment on macOS.
Ken Thomases
ken at codeweavers.com
Wed Mar 6 23:45:29 CST 2019
On Mar 6, 2019, at 9:28 PM, Chip Davis <cdavis at codeweavers.com> wrote:
>
> March 6, 2019 7:01 PM, "Ken Thomases" <ken at codeweavers.com> wrote:
>
>> On macOS, the .align <n> directive aligns to 2^n, not just n.
>
> I wonder if we should explicitly use '.balign 8', since that always means "align to 8 bytes." Unless, of course, there are platforms that don't support it.
This is a general issue that winebuild also explicitly contends with, and it isn't using .balign (nor .p2align). See tools/winebuild/utils.c:get_alignment(). So, I assume .balign isn't an acceptable solution. I'd be happy to be told otherwise, though.
-Ken
More information about the wine-devel
mailing list