[PATCH 08/10] d3dx9: Merge the d3dx_effect_GetIntArray() helper
Michael Stefaniuc
mstefani at winehq.org
Thu Mar 7 17:13:57 CST 2019
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
dlls/d3dx9_36/effect.c | 41 ++++++++++++++++-------------------------
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index b08344ca4b..1f7f22079b 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -1426,30 +1426,6 @@ static HRESULT d3dx9_base_effect_set_int_array(struct d3dx9_base_effect *base,
return D3DERR_INVALIDCALL;
}
-static HRESULT d3dx9_base_effect_get_int_array(struct d3dx9_base_effect *base,
- D3DXHANDLE parameter, INT *n, UINT count)
-{
- struct d3dx_parameter *param = get_valid_parameter(base, parameter);
-
- if (n && param && (param->class == D3DXPC_SCALAR
- || param->class == D3DXPC_VECTOR
- || param->class == D3DXPC_MATRIX_ROWS
- || param->class == D3DXPC_MATRIX_COLUMNS))
- {
- UINT i, size = min(count, param->bytes / sizeof(DWORD));
-
- for (i = 0; i < size; ++i)
- {
- set_number(&n[i], D3DXPT_INT, (DWORD *)param->data + i, param->type);
- }
- return D3D_OK;
- }
-
- WARN("Parameter not found.\n");
-
- return D3DERR_INVALIDCALL;
-}
-
static HRESULT d3dx9_base_effect_set_vector(struct d3dx9_base_effect *base,
D3DXHANDLE parameter, const D3DXVECTOR4 *vector)
{
@@ -3432,10 +3408,25 @@ static HRESULT WINAPI d3dx_effect_SetIntArray(ID3DXEffect *iface, D3DXHANDLE par
static HRESULT WINAPI d3dx_effect_GetIntArray(ID3DXEffect *iface, D3DXHANDLE parameter, INT *n, UINT count)
{
struct d3dx_effect *effect = impl_from_ID3DXEffect(iface);
+ struct d3dx_parameter *param = get_valid_parameter(&effect->base_effect, parameter);
TRACE("iface %p, parameter %p, n %p, count %u.\n", iface, parameter, n, count);
- return d3dx9_base_effect_get_int_array(&effect->base_effect, parameter, n, count);
+ if (n && param && (param->class == D3DXPC_SCALAR
+ || param->class == D3DXPC_VECTOR
+ || param->class == D3DXPC_MATRIX_ROWS
+ || param->class == D3DXPC_MATRIX_COLUMNS))
+ {
+ unsigned int i, size = min(count, param->bytes / sizeof(DWORD));
+
+ for (i = 0; i < size; ++i)
+ set_number(&n[i], D3DXPT_INT, (DWORD *)param->data + i, param->type);
+ return D3D_OK;
+ }
+
+ WARN("Parameter not found.\n");
+
+ return D3DERR_INVALIDCALL;
}
static HRESULT WINAPI d3dx_effect_SetFloat(ID3DXEffect *iface, D3DXHANDLE parameter, float f)
--
2.20.1
More information about the wine-devel
mailing list