[PATCH] msvcp90: Fix vtable alignment on macOS.

[Piotr Caban]

Hi Ken,

On 3/7/19 9:47 AM, Alexandre Julliard wrote:
> Ken Thomases <ken at codeweavers.com> writes:
> 
>> On Mar 6, 2019, at 9:28 PM, Chip Davis <cdavis at codeweavers.com> wrote:
>>>
>>> March 6, 2019 7:01 PM, "Ken Thomases" <ken at codeweavers.com> wrote:
>>>
>>>> On macOS, the .align <n> directive aligns to 2^n, not just n.
>>>
>>> I wonder if we should explicitly use '.balign 8', since that always means "align to 8 bytes." Unless, of course, there are platforms that don't support it.
>>
>> This is a general issue that winebuild also explicitly contends with,
>> and it isn't using .balign (nor .p2align).  See
>> tools/winebuild/utils.c:get_alignment().  So, I assume .balign isn't
>> an acceptable solution.  I'd be happy to be told otherwise, though.
> 
> It's not supported on Solaris, which was the reason for the winebuild
> code. I'm not sure if anybody still cares about Solaris nowadays...
Shouldn't it be changed on ARM, ARM64 and PowerPC as well? Maybe it's 
better to use .balign for all platforms except Solaris (or ignore 
Solaris until someone reports bug for it?).

Thanks,
Piotr