[PATCH v2] d3d10: Implement ID3D10EffectScalarVariable::{Get, Set}{Int, Float, Bool}

[Józef Kucia]

On Wed, Mar 13, 2019 at 7:05 PM Nick Renieris <velocityra at gmail.com> wrote:
> >Is it legal to call SetFloat() on boolean variables?
>
> As far as I'm aware the tests test against hardcoded values and not
> real D3D dlls, so how would a test help with that, if I don't even
> _know_ what the real library does (and I'm not allowed to reverse it +
> the docs don't explicitly mention)?
> The only thing I can think of is to write a test against the real D3D
> dlls or take a leap of faith and either do nothing, or return
> D3DERR_INVALIDCALL.

We run all our tests against Windows DLLs. The tests should pass on
Windows and on Wine. You may want to get a test bot account to run
your tests on our VMs [1].

As a side note, I expect that the correct behavior is to convert float
values to boolean values instead of doing data reinterpretation on the
byte level.

[1] - https://wiki.winehq.org/Wine_TestBot