[PATCH 5/6] quartz/systemclock: Don't check semaphore handle in SystemClockImpl_AdvisePeriodic().

Zebediah Figura z.figura12 at gmail.com
Wed Mar 13 23:59:09 CDT 2019


Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
 dlls/quartz/systemclock.c       | 3 ---
 dlls/quartz/tests/systemclock.c | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/quartz/systemclock.c b/dlls/quartz/systemclock.c
index 3da309bddf..66d439a22d 100644
--- a/dlls/quartz/systemclock.c
+++ b/dlls/quartz/systemclock.c
@@ -303,9 +303,6 @@ static HRESULT WINAPI SystemClockImpl_AdvisePeriodic(IReferenceClock* iface, REF
   TRACE("(%p, 0x%s, 0x%s, %ld, %p)\n", This, wine_dbgstr_longlong(rtStartTime),
       wine_dbgstr_longlong(rtPeriodTime), hSemaphore, pdwAdviseCookie);
 
-  if (!hSemaphore) {
-    return E_INVALIDARG;
-  }
   if (0 >= rtStartTime || 0 >= rtPeriodTime) {
     return E_INVALIDARG;
   }
diff --git a/dlls/quartz/tests/systemclock.c b/dlls/quartz/tests/systemclock.c
index bb89a39680..36e0cc0c92 100644
--- a/dlls/quartz/tests/systemclock.c
+++ b/dlls/quartz/tests/systemclock.c
@@ -150,7 +150,7 @@ static void test_advise(void)
     ok(SUCCEEDED(hr), "Got hr %#x.\n", hr);
 
     hr = IReferenceClock_AdvisePeriodic(clock, current, 500 * 10000, 0, &cookie);
-    todo_wine ok(hr == S_OK, "Got hr %#x.\n", hr);
+    ok(hr == S_OK, "Got hr %#x.\n", hr);
 
     hr = IReferenceClock_AdvisePeriodic(clock, current, 500 * 10000, (HSEMAPHORE)semaphore, NULL);
     ok(hr == E_POINTER, "Got hr %#x.\n", hr);
-- 
2.20.1




More information about the wine-devel mailing list