[PATCH vkd3d 1/8] vkd3d: Do not ignore "src_box" in d3d12_command_list_CopyTextureRegion().

[Józef Kucia]

On Mon, Mar 18, 2019 at 3:30 PM Henri Verbeet <hverbeet at gmail.com> wrote:
>
> On Mon, 18 Mar 2019 at 12:33, Józef Kucia <joseph.kucia at gmail.com> wrote:
> > +    if (src_box)
> > +    {
> > +        VkDeviceSize row_count = footprint->Footprint.Height / format->block_height;
> I'm not entirely sure whether this can happen in d3d12, but note that
> this wouldn't work for cases where the height isn't a multiple of the
> block width. (Like for example the smallest mip-levels of compressed
> textures. There's test_invalid_copy_texture_region(), but it doesn't
> seem to test that particular case.) For comparison, see also
> wined3d_format_calculate_pitch() in wined3d.

I submitted another test that shows that even for the smallest
mip-levels the application is supposed to align src_box to block
sizes.