[PATCH 3/6] d3dx9: Avoid using This in d3dx_effect_Clone()

Michael Stefaniuc mstefani at winehq.org
Fri Mar 22 02:47:27 CDT 2019


Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
 dlls/d3dx9_36/effect.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 3e31d65226..b26740ab6b 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -4085,17 +4085,17 @@ static HRESULT WINAPI d3dx_effect_DeleteParameterBlock(ID3DXEffect *iface, D3DXH
 }
 #endif
 
-static HRESULT WINAPI d3dx_effect_CloneEffect(ID3DXEffect *iface, struct IDirect3DDevice9 *device,
-        struct ID3DXEffect **effect)
+static HRESULT WINAPI d3dx_effect_CloneEffect(ID3DXEffect *iface, IDirect3DDevice9 *device,
+        ID3DXEffect **new_effect)
 {
-    struct d3dx_effect *This = impl_from_ID3DXEffect(iface);
+    struct d3dx_effect *effect = impl_from_ID3DXEffect(iface);
 
-    FIXME("(%p)->(%p, %p): stub\n", This, device, effect);
+    FIXME("iface %p, device %p, new_effect %p stub.\n", effect, device, new_effect);
 
-    if (!effect)
+    if (!new_effect)
         return D3DERR_INVALIDCALL;
 
-    if (This->base_effect.flags & D3DXFX_NOT_CLONEABLE)
+    if (effect->base_effect.flags & D3DXFX_NOT_CLONEABLE)
         return E_FAIL;
 
     if (!device)
-- 
2.20.1




More information about the wine-devel mailing list