[PATCH 6/6] d3dx9: Secure against unsafe iface to COM object transitions

Chip Davis cdavis at codeweavers.com
Fri Mar 22 08:37:16 CDT 2019


March 22, 2019 2:49 AM, "Michael Stefaniuc" <mstefani at winehq.org> wrote:

> @@ -6162,7 +6164,7 @@ static HRESULT d3dx9_effect_init(struct d3dx_effect *effect, struct IDirect3DDev
>      if (pool)
>      {
>          pool->lpVtbl->AddRef(pool);
> -        effect->pool = impl_from_ID3DXEffectPool(pool);
> +        effect->pool = unsafe_impl_from_ID3DXEffectPool(pool);
>      }

Now you are leaking 'pool' in case it's not one of ours.

Chip



More information about the wine-devel mailing list