[PATCH] schedsvc/tests: Avoid a crash in a SchRpcRegisterTask test

Detlef Riekenberg wine.dev at web.de
Thu Mar 21 08:37:18 CDT 2019


Example failures:
(full report with 90 failures after upgrading from win7 to win10)
http://test.winehq.org/queue/errksCfJ/report
cw1 (1709):
http://test.winehq.org/data/6325d85406fbf7f46770bc739da4b7e2c9b199d7/win10_cw1-hd6800-1709-t64/schedsvc:rpcapi.html

patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=49726

The test crashed on some win10 systems since a long time,
but some old win10 machines works.
Microsoft proably changed something.

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg <wine.dev at web.de>
---
 dlls/schedsvc/tests/rpcapi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/schedsvc/tests/rpcapi.c b/dlls/schedsvc/tests/rpcapi.c
index 4aaafb60f1..c15ef131ff 100644
--- a/dlls/schedsvc/tests/rpcapi.c
+++ b/dlls/schedsvc/tests/rpcapi.c
@@ -526,6 +526,11 @@ todo_wine
     path = NULL;
     info = NULL;
     hr = SchRpcRegisterTask(NULL, xmlW, TASK_CREATE, NULL, TASK_LOGON_NONE, 0, NULL, &path, &info);
+    if (hr == E_ACCESSDENIED)
+    {
+        skip("Access denied for TASK_CREATE with a NULL path\n");
+        goto done;
+    }
     ok(hr == S_OK, "expected S_OK, got %#x\n", hr);
     ok(!info, "expected NULL, info %p\n", info);
     hr = IIDFromString(path, &iid);
@@ -534,6 +539,7 @@ todo_wine
     ok(hr == S_OK, "expected S_OK, got %#x\n", hr);
     MIDL_user_free(path);

+done:
     hr = RpcBindingFree(&rpc_handle);
     ok(hr == RPC_S_OK, "RpcBindingFree error %#x\n", hr);
 }
--
2.21.0.windows.1




More information about the wine-devel mailing list