[PATCH] secur32: Handle a new, undefined SECPKG_FLAG value [untested]
Dmitry Timoshkov
dmitry at baikal.ru
Thu Mar 28 02:56:42 CDT 2019
Detlef Riekenberg <wine.dev at web.de> wrote:
> +/* FIXME: Microsoft is using 0x02000000 (not defined in the 10.0.17763 SDK) */
> +#define SECPKG_FLAG_0x02000000 0x02000000
> +
> static HMODULE secdll;
>
> static SECURITY_STATUS (SEC_ENTRY *pSspiEncodeAuthIdentityAsStrings)
> @@ -440,7 +443,8 @@ static void test_kerberos(void)
> | SECPKG_FLAG_READONLY_WITH_CHECKSUM;
> static const ULONG optional_mask =
> SECPKG_FLAG_RESTRICTED_TOKENS
> - | SECPKG_FLAG_APPCONTAINER_CHECKS;
> + | SECPKG_FLAG_APPCONTAINER_CHECKS
> + | SECPKG_FLAG_0x02000000;
There is no need to invent a new flag name, just use 0x02000000 directly.
> #define SECPKG_FLAG_RESTRICTED_TOKENS 0x00080000
> #define SECPKG_FLAG_NEGO_EXTENDER 0x00100000
> #define SECPKG_FLAG_NEGOTIABLE2 0x00200000
> -#define SECPKG_FLAG_APPCONTAINER_PASSTHROUGH 0x00400000
> -#define SECPKG_FLAG_APPCONTAINER_CHECKS 0x00800000
> +#define SECPKG_FLAG_APPCONTAINER_PASSTHROUGH 0x00400000
> +#define SECPKG_FLAG_APPCONTAINER_CHECKS 0x00800000
> +#define SECPKG_FLAG_CREDENTIAL_ISOLATION_ENABLED 0x01000000
> +/* FIXME: Microsoft is using 0x02000000 (not defined in the 10.0.17763 SDK) */
It's not useful to add this kind of comments to the public header.
--
Dmitry.
More information about the wine-devel
mailing list