[PATCH 1/2] dinput: Trace This pointer in a consistent way

Matteo Bruni matteo.mystral at gmail.com
Tue May 7 18:16:25 CDT 2019


Hi Alistair,

not commenting on the patch idea, just something I noticed:

On Tue, May 7, 2019 at 5:17 AM Alistair Leslie-Hughes
<leslie_alistair at hotmail.com> wrote:
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> ---
>  dlls/dinput/device.c              | 73 ++++++++++++++++++++++++---------------
>  dlls/dinput/dinput_main.c         |  4 +--
>  dlls/dinput/joystick.c            | 10 +++---
>  dlls/dinput/joystick_linux.c      |  2 +-
>  dlls/dinput/joystick_linuxinput.c |  2 +-
>  dlls/dinput/joystick_osx.c        |  4 +--
>  dlls/dinput/keyboard.c            |  8 +++--
>  dlls/dinput/mouse.c               |  3 +-
>  8 files changed, 63 insertions(+), 43 deletions(-)
>
> diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c
> index cfade08..ff9bbfb 100644
> --- a/dlls/dinput/device.c
> +++ b/dlls/dinput/device.c
> @@ -1181,7 +1181,7 @@ HRESULT WINAPI IDirectInputDevice2WImpl_QueryInterface(LPDIRECTINPUTDEVICE8W ifa
>  {
>      IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface);
>
> -    TRACE("(%p this=%p,%s,%p)\n", iface, This, debugstr_guid(riid), ppobj);
> +    TRACE("(%p) %s,%p)\n", This, debugstr_guid(riid), ppobj);

That's probably too many closed parentheses. More of the same below.



More information about the wine-devel mailing list