[PATCH] ntdll: Check for debug output buffer overflow in __wine_dbg_output().

[Alexandre Julliard]

Zebediah Figura <z.figura12 at gmail.com> writes:

> On 5/13/19 5:42 AM, Alexandre Julliard wrote:
>> Józef Kucia <jkucia at codeweavers.com> writes:
>>
>>> This makes __wine_dbg_output() slightly more robust. The change prevents the
>>> debug output buffer overflow when __wine_dbg_output() is called repeatedly
>>> with small strings.
>>
>> The goal is to only output complete lines, otherwise it makes a mess of
>> the output. If some code overflows the line buffer that's a bug.
>>
>
> While avoiding mixed output from multiple threads is certainly a
> desirable goal, I've been stymied multiple times by not being able to
> read very long strings in debug output [e.g.: GStreamer caps,
> parameters passed to MsiInstallProduct()]. How do you recommend we
> deal with those?

You should make an effort to format the output properly, instead of
dumping everything on a single line. That's annoying to read even when
not mixed with other output.

-- 
Alexandre Julliard
julliard at winehq.org