[PATCH 1/2] windowscodecs: Improve compatibility of IMILBitmapSource interface.

Dmitry Timoshkov dmitry at baikal.ru
Mon May 13 11:36:19 CDT 2019


"Vincent Povirk (they/them)" <vincent at codeweavers.com> wrote:

>  static HRESULT WINAPI IMILUnknown1Impl_QueryInterface(IMILUnknown1
> *iface, REFIID iid,
>      void **ppv)
>  {
> -    BitmapImpl *This = impl_from_IMILUnknown1(iface);
> -
> -    TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv);
> -
> -    if (!ppv) return E_INVALIDARG;
> -
> -    if (IsEqualIID(&IID_IUnknown, iid))
> -    {
> -        IUnknown_AddRef(&This->IMILUnknown1_iface);
> -        *ppv = iface;
> -        return S_OK;
> -    }
> -
> -    return IWICBitmap_QueryInterface(&This->IWICBitmap_iface, iid, ppv);
> +    FIXME("(%p,%s,%p): stub\n", iface, debugstr_guid(iid), ppv);
> +    *ppv = NULL;
> +    return E_NOINTERFACE;
>  }
> 
> Why are we removing this? Does native violate COM rules by not
> returning an interface for IUnknown?

According to the test app that I have here that's how it behaves.

-- 
Dmitry.



More information about the wine-devel mailing list