[resend PATCH] shell32: Implement NewMenu with new folder item.

Nikolay Sivov bunglehead at gmail.com
Mon May 13 16:31:18 CDT 2019


On Tue, May 14, 2019 at 12:23 AM Vijay Kiran Kamuju <infyquest at gmail.com>
wrote:

> On Mon, May 13, 2019 at 1:23 PM Alexandre Julliard <julliard at winehq.org>
> wrote:
> >
> > Vijay Kiran Kamuju <infyquest at gmail.com> writes:
> >
> > > @@ -32,6 +32,7 @@ C_SRCS = \
> > >       shelldispatch.c \
> > >       shellitem.c \
> > >       shelllink.c \
> > > +     shellnew.c \
> >
> > Please use a better name, or preferably put this into some existing file
> > like shlmenu.c.
> This cannot be put into existing files like shlmenu.c or
> shlview_cmenu.c as it we need separate implementations of
> IContextMenu3 and IShellExtInit.
> Please let me know if the filename like shlview_nmenu.c or
> shlview_newmenu.c is ok or not.
>

Maybe it's possible to unify some of that. Shell32 has enough duplication
already. If not, nothing prevents from having two objects implementing same
interface in the same file.


> ---
> Vijay
> >
> > --
> > Alexandre Julliard
> > julliard at winehq.org
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190514/7141822a/attachment.html>


More information about the wine-devel mailing list