[PATCH 1/3] server: Return successful select result separately from select request result.

Jacek Caban jacek at codeweavers.com
Tue May 14 09:02:20 CDT 2019


On 5/13/19 8:14 PM, Alexandre Julliard wrote:
> Jacek Caban <jacek at codeweavers.com> writes:
>
>> Allows returning to caller arbitrary status including values that
>> would be otherwise have special meaning for client.
> That series doesn't look very nice. Do we really need all that
> complexity?
>
> It seems to me it would be easier to use some different status values
> just for the async case, and leave the rest of the code alone.


Part of my consideration was that the problem is not limited to pending 
return. Errors reported by IRP dispatcher may also need to return status 
code without touching status block. select complication is indeed not 
pretty, but server_*_file part seems nice. I attached patches 
implementing pending blocking for the context.


I also attached tests showing possible further problem with errors. I 
didn't implement the error behaviour and I'm not aware of an application 
that needs this, but on top of that series it should not need more 
protocol changes. Anyway, I will look for less invasive solution if you 
prefer.


Thanks,

Jacek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-server-Store-pending-flag-in-async-object.diff
Type: text/x-patch
Size: 3218 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190514/2431410b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-server-Always-block-overlapped-device-requests-until-.diff
Type: text/x-patch
Size: 8092 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190514/2431410b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ntoskrnl.exe-tests-Add-more-overlapped-error-tests.diff
Type: text/x-patch
Size: 3588 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190514/2431410b/attachment-0002.bin>


More information about the wine-devel mailing list