[PATCH v3 1/6] winex11.drv: Support multiple display device handlers.

Huw Davies huw at codeweavers.com
Thu May 16 04:33:12 CDT 2019


On Tue, May 14, 2019 at 05:48:12PM +0800, Zhiyi Zhang wrote:
> Display device handler will be used to initialize the registry.
> Different handlers can be implemented according to the interface,
> for example, via Xinerama or XRandR. With those registry data,
> EnumDisplayDevices, EnumDisplayMonitors and GetMonitorInfo can be
> built on top of it.

Patches 1 and 2 contain mostly dead code; basically nothing happens
until patch 3.  What you want is for the first patch to do something
useful (like write a bit of information to the registry) and build up
from there.  This may mean that the first patch is larger than ideal,
but it should be possible to do it in a way that its not too big.

A more general point: I see that you have patches for Xrandr 1.4 in
your tree.  Do we actually care about Xinerama if we can get
everything we need from Xrandr?  Xrandr 1.4 is more than five years
old right?

Huw.



More information about the wine-devel mailing list