[PATCH v3 1/6] winex11.drv: Support multiple display device handlers.

[Zhiyi Zhang]

On 5/16/19 5:33 PM, Huw Davies wrote:
> On Tue, May 14, 2019 at 05:48:12PM +0800, Zhiyi Zhang wrote:
>> Display device handler will be used to initialize the registry.
>> Different handlers can be implemented according to the interface,
>> for example, via Xinerama or XRandR. With those registry data,
>> EnumDisplayDevices, EnumDisplayMonitors and GetMonitorInfo can be
>> built on top of it.
> Patches 1 and 2 contain mostly dead code; basically nothing happens
> until patch 3.  What you want is for the first patch to do something
> useful (like write a bit of information to the registry) and build up
> from there.  This may mean that the first patch is larger than ideal,
> but it should be possible to do it in a way that its not too big.
Sure. I will merge it.
>
> A more general point: I see that you have patches for Xrandr 1.4 in
> your tree.  Do we actually care about Xinerama if we can get
> everything we need from Xrandr?  Xrandr 1.4 is more than five years
> old right?
The reason why I also do it for Xinerama is in case XRandR is unavailable.
Also Xinerama is currently used over XRandR when in desktop mode, I don't think we want to
report multiple adapters or monitors when in desktop mode. We could only support
XRandR but that would mean migrate some desktop mode code to XRandR as well
and risks XRandR being unavailable.

Yes, XRandR 1.4 is more than fives years old.

Thanks,
Zhiyi
>
> Huw.