[PATCH v2 3/7] wined3d: Implement lighting with directional lights in process_vertices_strided().

Henri Verbeet hverbeet at gmail.com
Fri May 17 10:42:38 CDT 2019


On Fri, 17 May 2019 at 19:48, Paul Gofman <gofmanp at gmail.com> wrote:
> Do you suggest to use wined3d_ffp_get_vs_settings() directly? It
> probably needs some redesign first for that, as it uses gl_info and
> hardware limits (light count, as well as bitfields in settings
> structure). Or do you mean factoring out some functions like
> init_light_sources() to use in process_vertices_strided() and
> init_light_settings() which would use some more generic structure and
> parameters not to depend on GL limits?
>
My thinking was to just use it as-is, and then either ignore or fix-up
the differences afterwards. Light counts would have to be handled
separately because of the bitfield sizes, but that's fairly
straight-forward code.



More information about the wine-devel mailing list