[PATCH vkd3d 2/3] vkd3d: Support count buffer for indirect draws
Józef Kucia
joseph.kucia at gmail.com
Mon May 20 02:22:02 CDT 2019
Thanks for the patches. I submitted a v2 with some modifications.
On Sat, May 18, 2019 at 4:34 PM Philip Rebohle
<philip.rebohle at tu-dortmund.de> wrote:
> - VK_CALL(vkCmdDrawIndirect(list->vk_command_buffer, arg_impl->u.vk_buffer,
> - arg_buffer_offset, max_command_count, signature_desc->ByteStride));
> + if (!count_buffer) {
> + VK_CALL(vkCmdDrawIndirect(list->vk_command_buffer, arg_impl->u.vk_buffer,
> + arg_buffer_offset, max_command_count, signature_desc->ByteStride));
> + } else {
> + VK_CALL(vkCmdDrawIndirectCountKHR(list->vk_command_buffer, arg_impl->u.vk_buffer,
> + arg_buffer_offset, count_impl->u.vk_buffer, count_buffer_offset,
> + max_command_count, signature_desc->ByteStride));
> + }
> break;
Coding style.
> + if (count_buffer) {
> + WARN("Count buffers not supported for indirect dispatch.\n");
> + break;
> + }
We use FIXME() for missing functionality.
More information about the wine-devel
mailing list