[PATCH v2 2/2] mshtml: Avoid passing invalid memory to DispCallFunc().

Zebediah Figura z.figura12 at gmail.com
Mon May 20 10:32:16 CDT 2019


Hello Jacek,

On 5/20/19 7:24 AM, Jacek Caban wrote:
> On 5/19/19 9:40 PM, Zebediah Figura wrote:
>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47222
>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>> ---
>>    dlls/mshtml/dispex.c | 5 ++++-
>>    1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
>> index 2033e90872..88a5e5168e 100644
>> --- a/dlls/mshtml/dispex.c
>> +++ b/dlls/mshtml/dispex.c
>> @@ -1129,6 +1129,7 @@ static HRESULT builtin_propput(DispatchEx *This, func_info_t *func, DISPPARAMS *
>>    static HRESULT invoke_builtin_function(DispatchEx *This, func_info_t *func, DISPPARAMS *dp, VARIANT *res, IServiceProvider *caller)
>>    {
>>        VARIANT arg_buf[MAX_ARGS], *arg_ptrs[MAX_ARGS], *arg, retv, ret_ref, vhres;
>> +    VARTYPE arg_types[MAX_ARGS];
> 
> 
> We could probably populate arg_types with return value pointer in
> add_func_info().

Sure, I'll send a new patch using this approach.

> 
> 
> Thanks,
> 
> Jacek
> 
> 
> 



More information about the wine-devel mailing list