[PATCH v2 3/7] wined3d: Implement lighting with directional lights in process_vertices_strided().

Henri Verbeet hverbeet at gmail.com
Mon May 20 16:03:44 CDT 2019


On Sun, 19 May 2019 at 02:10, Matteo Bruni <matteo.mystral at gmail.com> wrote:
> I'd try with the latter first. Moving process_vertices() over to the
> CS thread seems awkward to me.
>
Yeah.

> FWIW we should probably get rid of the struct gl_info uses in
> wined3d_ffp_get_vs_settings(), maybe by setting a flag in d3d_info if
> we have enough (backend / GL) varyings to support all the fixed
> function (d3d) varyings. Actually, all the uses of
> wined3d_max_compat_varyings() are like that, we could get rid of the
> function entirely.
> I can write the patch if you haven't already.
>
I think that makes sense. (And no, I haven't written that yet.)

> That aside, I think wined3d_ffp_get_vs_settings() shouldn't have a
> context parameter but simply get stream_info and d3d_info from the
> caller. You want to pass your own stream_info from
> wined3d_device_process_vertices() anyway and you can get to d3d_info
> from device->adapter.

I think that makes sense too.



More information about the wine-devel mailing list