[PATCH v2 1/2] gdi32: Add tests for CreatePolyPolygonRgn

Huw Davies huw at codeweavers.com
Tue May 21 04:54:32 CDT 2019


On Sun, May 19, 2019 at 04:31:45PM +0200, Fabian Maurer wrote:
> Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
> ---
>  dlls/gdi32/tests/clipping.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/dlls/gdi32/tests/clipping.c b/dlls/gdi32/tests/clipping.c
> index 60bd31e8e4..5a8a8b0c2a 100644
> --- a/dlls/gdi32/tests/clipping.c
> +++ b/dlls/gdi32/tests/clipping.c
> @@ -533,6 +533,38 @@ static void test_window_dc_clipping(void)
>      DestroyWindow(hwnd);
>  }
> 
> +static void test_CreatePolyPolygonRgn(void)
> +{
> +    HRGN region;
> +    POINT points_zero[] = { {0, 0}, {0, 0}, {0, 0} };
> +    POINT points_mixed[] = { {0, 0}, {0, 0}, {0, 0}, {6, 6}, {6, 6}, {6, 6} };
> +    POINT points_six[] = { {6, 6}, {6, 6}, {6, 6} };
> +    POINT points_line[] = { {1, 0}, {11, 0}, {21, 0}};
> +    INT counts_single_poly[] = { 3 };
> +    INT counts_two_poly[] = { 3, 3 };
> +
> +    /* When all polygons are just one point or line, return must not be NULL */
> +
> +    region = CreatePolyPolygonRgn(points_zero, counts_single_poly, ARRAY_SIZE(counts_single_poly), ALTERNATE);
> +    todo_wine
> +    ok (region != NULL, "region must not be NULL\n");

It would be good to check the GetRgnBox() returns an empty rectangle.

Also, since the implementation change is so small, merging these two
patches together would probably be simpler.

Huw.



More information about the wine-devel mailing list