[PATCH 2/2] urlmon: If ProtocolCF_CreateInstance doesn't support aggregation retry without it.

Jacek Caban jacek at codeweavers.com
Tue May 21 06:43:07 CDT 2019


Hi Dmitry,

On 5/21/19 12:33 PM, Dmitry Timoshkov wrote:
> Jacek Caban <jacek at codeweavers.com> wrote:
>
>> Those changes look mostly good, but we should probably not forward QI
>> calls in BindProtocol_QueryInterface if the protocol doesn't support
>> aggregation.
>>
>> Also I don't mind tests from patch 1, but it would be probably easier to
>> extend test_CreateBinding(). It would also make a testing the above
>> comment trivial.
> I've moved the tests to test_CreateBinding(), however making them pass
> requires more knowledge about interaction between the object and outer
> interface, I'd appreciate your help with it, I miss an outer reference
> count decrease somewhere, and couldn't figure this out yet.


Please test the attached patch with your application.


Jacek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 1207 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190521/b9c95140/attachment.bin>


More information about the wine-devel mailing list