[PATCH] dinput/tests: Remove unrequired if (Coverity)

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Sun May 26 17:49:21 CDT 2019


Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
---
 dlls/dinput/tests/keyboard.c | 2 +-
 dlls/dinput/tests/mouse.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dinput/tests/keyboard.c b/dlls/dinput/tests/keyboard.c
index 9254123..d6ab5b5 100644
--- a/dlls/dinput/tests/keyboard.c
+++ b/dlls/dinput/tests/keyboard.c
@@ -479,7 +479,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI)
             wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) );
     ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType);
 
-    if (pKey) IUnknown_Release(pKey);
+    IUnknown_Release(pKey);
 }
 
 static void keyboard_tests(DWORD version)
diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c
index c5cb684..e4d24e8 100644
--- a/dlls/dinput/tests/mouse.c
+++ b/dlls/dinput/tests/mouse.c
@@ -224,7 +224,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI)
             wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) );
     ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType);
 
-    if (pMouse) IUnknown_Release(pMouse);
+    IUnknown_Release(pMouse);
 }
 
 static BOOL CALLBACK EnumAxes(const DIDEVICEOBJECTINSTANCEA *pdidoi, void *pContext)
-- 
1.9.1



More information about the wine-devel mailing list