[PATCH] shell32: Fix a use after free (Coverity).
Sven Baars
sven.wine at gmail.com
Tue May 28 16:51:04 CDT 2019
Signed-off-by: Sven Baars <sven.wine at gmail.com>
---
dlls/shell32/shellitem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c
index fc95e7c227..b9e4903a97 100644
--- a/dlls/shell32/shellitem.c
+++ b/dlls/shell32/shellitem.c
@@ -1289,9 +1289,11 @@ HRESULT WINAPI SHCreateShellItemArray(PCIDLIST_ABSOLUTE pidlParent,
if(SUCCEEDED(ret))
{
ret = create_shellitemarray(array, cidl, ppsiItemArray);
- heap_free(array);
if(SUCCEEDED(ret))
+ {
+ heap_free(array);
return ret;
+ }
}
/* Something failed, clean up. */
--
2.17.1
More information about the wine-devel
mailing list