[PATCH v4 3/6] kernel32/tests: Add tests for NtAllocateVirtualMemory with size_ptr == NULL

Huw Davies huw at codeweavers.com
Wed May 29 05:02:12 CDT 2019


On Wed, May 29, 2019 at 11:53:49AM +0200, RĂ©mi Bernon wrote:
> Alright. About the crash, it mainly depends on the order of the patch
> set as it's fixed in the next patch. I'm not sure how the order should
> be in general (or should tests + fixes be mixed in a single patch?).

One way is to add tests with todos in one patch, then add the
implementation and remove the todos in a following patch.  The
advantage of this is that it's clear which tests your patch fixes.
Sometimes it's not practical to add the tests first, so then an
implementation patch followed by a test patch is fine.  If everything
is small then you can combine the tests with the implementation in one
patch.

The important point though is that the tests must succeed after each
patch.

Huw.



More information about the wine-devel mailing list